[Buildroot] [PATCH 2/9] firefox: valgrind dependency needs --enable-tls for debug build
Stefan Fröberg
stefan.froberg at petroprogram.com
Tue Sep 11 23:39:37 UTC 2012
12.9.2012 1:04, Arnout Vandecappelle kirjoitti:
> On 09/05/12 16:28, Stefan Fröberg wrote:
>> +ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)&& ($(BR2_GCC_ENABLE_TLS),y)
>> +VALGRIND_CONF_OPT = --enable-tls
>> +else
>> VALGRIND_CONF_OPT = --disable-tls
>> +endif
>
> I don't like this because it only works for internal toolchains.
>
> Is it possible to remove the --en/disable-tls and let configure
> discover it by
> itself? I tried a few configs and it seems to work correctly... The
> --disable-tls was introduced by a version bump 7 years ago, without any
> comment why it is needed. It may have caused runtime problems, but those
> may have disappeared by now too. So I'd risk removing it completely.
>
Firefox did not complain about missing valgrind.h file ???
Strange...
I have to try to make a debug build of FF again and valgrind with
--disable-tls and see
Stefan
> Regards,
> Arnout
More information about the buildroot
mailing list