[Buildroot] [PATCH v2 3/7] arch: toolchain: Introduce binary formats BINFMT_*.

[Sonic Zhang]

Hi Thomas,

On Mon, Apr 8, 2013 at 4:45 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Sonic Zhang,
>
> On Fri, 29 Mar 2013 17:50:39 +0800, Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang at analog.com>
>>
>> v2-changes:
>> none
>>
>> v1-changes:
>> - Just introduce the symbol and options in arch generic Config.in.
>> Append FLAT format link flags to external toolchain wrapper.
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang at analog.com>
>
> As detailed in my comments to PATCH 1/7, this patch needs to be
> refactored with BR2_BFIN_FDPIC/BR2_BFIN_FLAT to avoid breaking existing
> code.

OK.

>
> Also, I believe we want to add some architecture dependencies here. For
> the beginning, we at least want something like:
>
> +# Set up target binary format
> +choice
> +       prompt "Target Binary Format"
> +       default BR2_BINFMT_ELF
> +config BR2_BINFMT_ELF
> +       bool "ELF"
> +       depends on !BR2_bfin
> +config BR2_BINFMT_FDPIC
> +       bool "FDPIC"
> +       depends on BR2_bfin
> +config BR2_BINFMT_FLAT
> +       bool "FLAT"
> +       select BR2_PREFER_STATIC_LIB
> +       depends on BR2_bfin
> +endchoice
>

No problem.

Regards,

Sonic