[Buildroot] [PATCH 1/1] fs: add uimage support w/ example for cpio

Spenser Gilliland spenser at gillilanding.com
Wed Apr 17 20:57:51 UTC 2013


Soren,

Thanks for the tips.  I appreciate the tips. I'll be sure to use those
options in the future.

Spenser

On Wed, Apr 17, 2013 at 3:56 PM, Sören Brinkmann
<soren.brinkmann at xilinx.com> wrote:
> Hi Spenser,
>
> On Wed, Apr 17, 2013 at 03:19:40PM -0500, Spenser Gilliland wrote:
>> Soren,
>>
>> Yes, you were right.  The patch did not have the whitespace fixes.
>> Either git format-patch doesn't overwrite old patches or I used the
>> old ref when I rebased for the whitespace fix.  Still very new to git
>> send-email and format-patch.
> Okay, then as further tips:
> It is usually good practice to mark new revisions of a patch as such, by
> adding a 'v2' (for the second version) to the subject. Either by specifying
> '--subject-prefix' or on later git versions '--reroll-count' when running
> format-patch.
>
> And a changelog should be sent with the patch and usually goes after the
> line with the three dashes in the same email. The text after the '---'
> is not part of the commit message.
>
>         Regards,
>         Sören
>
>



-- 
Spenser Gilliland
Computer Engineer
Doctoral Candidate



More information about the buildroot mailing list