[Buildroot] [PATCH 2/3] ltrace: Fix a May be unitialized variable

Baruch Siach baruch at tkos.co.il
Fri Aug 9 10:20:39 UTC 2013


Hi Jérôme,

On Fri, Aug 09, 2013 at 11:36:58AM +0200, Jérôme Pouiller wrote:
> Compilation may failed if rlm is not initialized and ltrace
> is compiled with -Werror.

The right fix, in my opinion, is to disable -Werror. Otherwise, we'll have to 
add more and more fixes like this one for each bump of the toolchain.

baruch

> Signed-off-by: Jérôme Pouiller <jezz at sysmic.org>
> ---
>  .../ltrace-fix-may-be-uninitialized-variable.patch |   11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch
> 
> diff --git a/package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch b/package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch
> new file mode 100644
> index 0000000..23ffc94
> --- /dev/null
> +++ b/package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch
> @@ -0,0 +1,11 @@
> +--- a/sysdeps/linux-gnu/proc.c	2012-12-04 13:36:23.000000000 +0100
> ++++ b/sysdeps/linux-gnu/proc.c	2013-08-09 10:14:33.576464435 +0200
> +@@ -483,7 +483,7 @@
> + 	arch_addr_t addr = (arch_addr_t)(uintptr_t)dbg->r_map;
> + 
> + 	while (addr != 0) {
> +-		struct lt_link_map_64 rlm;
> ++		struct lt_link_map_64 rlm = { };
> + 		if (lm_fetcher(proc)(proc, addr, &rlm) < 0) {
> + 			debug(2, "Unable to read link map");
> + 			return;
> -- 
> 1.7.9.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list