[Buildroot] [PATCH 3/3] ltrace: Fix "strndup not declared" build failure on powerpc/uclibc

[Thomas De Schampheleire]

On Fri, Aug 9, 2013 at 12:29 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Jérôme Pouiller,
>
> On Fri,  9 Aug 2013 11:36:59 +0200, Jérôme Pouiller wrote:
>> On some systems, strndup is declared only if _GNU_SOURCE is defined
>>
>> Signed-off-by: Jérôme Pouiller <jezz at sysmic.org>
>
> Shouldn't this be globally defined by adding a -D_GNU_SOURCE to the
> CFLAGS at the package level?

When you say 'package level' you mean in ltrace.mk in buildroot?
In this case I don't think it's correct: ltrace itself is responsible
for including the right header files, and setting the right macros, so
that any used interface is available. Hence, I consider it a patch to
ltrace (that should be upstreamed), not something we should fix in
buildroot itself.