[Buildroot] [PATCH] libsecret: New package

[Gustavo Zacarias]

On 08/15/2013 07:56 AM, Markos Chandras wrote:
> Hi Gustavo,
> 
> Thanks for the review.
> 
> Would it be better to replace 'select' with 'depend' to avoid
> implicitly enabling these toolchain components?

Hi.
For libglib2 and other hard dependencies we usually just depend on the
toolchain components being available and select libglib2 like you did
with a nice comment when the toolchain isn't up to the requirements
saying so...

comment "libsecret requires a toolchain with X and Y support".
depends on !BR2_TOOLCHAIN_HAS_X || !BR2_TOOLCHAIN_HAS_Y
(with the appropiate labels of course!)

Only when there's a real choice (say, two different libglib2
implementations) a depend would be appropiate (xorg is a good example
since there's a choice between full and kdrive/tinyx, and it usually
requires extra configuration - drivers).

Enabling toolchain components is bad, if it did and you add a package as
a later thought after building your basic system you mess things up.

Regards.