[Buildroot] [PATCH] openssh: fix tab/spacing in init script
Arnout Vandecappelle
arnout at mind.be
Thu Aug 22 16:11:37 UTC 2013
On 22/08/13 15:59, Thomas De Schampheleire wrote:
>> >I'd be willing to go through all of them and make them uniform, if
>> >recommended guidelines can be stated with regards to the above variations.
>> >Tabs are tempting only because it's a single character in text files that go
>> >in the target - otherwise, I'm normally in the tabs-are-evil camp, since
>> >thing which start out with tabs tend get modified with spaces over time, and
>> >because editor rendering of tab width can vary. So I'd be willing to go
>> >either way.
> Thanks for checking. Seems there was more variance than I expected.
>
> I'm not sure what to do here. Unless such init scripts have been
> copied from elsewhere (in which making cosmetic changes may be
> undesirable), I'm ok with having them changed according to a given
> guideline.
If it is copied from elsewhere then it probably shouldn't be in
buildroot, but just copied from elsewhere.
> Before trying to establish such a guideline, what does the community
> think about this?
> If there is no consensus in changing, then no need for a guideline.
I guess that's a judgement call for Peter to make.
Note that we also have this kind of whitespace inconsistencies in e.g.
support/scripts.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
More information about the buildroot
mailing list