[Buildroot] [PATCH 1/1] knock: new package
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat Aug 31 11:50:01 UTC 2013
Dear Michael Rommel,
Thanks for your contribution! I won't repeat the comments made by
Thomas De Schampheleire since they are all obviously valid. Let me add
one other nitpick comment below.
On Fri, 30 Aug 2013 23:47:16 +0200, Michael Rommel wrote:
> +KNOCK_VERSION=7666f2e86e18d482eaad5fe1fea46d87d80b0555
> +KNOCK_SITE=https://github.com/jvinet/knock/tarball/master
There should be spaces around the equal sign, like you did in the lines
below.
> +KNOCK_LICENSE = GPLv2
Is it really GPLv2 or GPLv2+ ? Can you check the copyright headers in
the source files?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list