[Buildroot] [PATCH 1/2] package: unification of name <pkg>_VERSION_MAJOR variable

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Dec 2 08:53:32 UTC 2013


Jerzy,

On Mon, 2 Dec 2013 09:52:37 +0100, Thomas Petazzoni wrote:
> Dear Jerzy Grzegorek,
> 
> On Mon,  2 Dec 2013 09:00:02 +0100, Jerzy Grzegorek wrote:
> 
> > -JSON_GLIB_VERSION = $(JSON_GLIB_MAJOR_VERSION).$(JSON_GLIB_MINOR_VERSION)
> > -JSON_GLIB_SITE = http://ftp.gnome.org/pub/GNOME/sources/json-glib/$(JSON_GLIB_MAJOR_VERSION)
> > +JSON_GLIB_VERSION = $(JSON_GLIB_VERSION_MAJOR).$(JSON_GLIB_MINOR_VERSION)
> 
> So we have VERSION_MAJOR and then MINOR_VERSION ? Doesn't seem really
> consistent.

Ok, ignore that comment, sorry. I did review PATCH 1/2, and only after
that I saw PATCH 2/2. So just ignore my stupidity :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list