[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

Peter Korsgaard jacmet at uclibc.org
Mon Dec 16 15:14:19 UTC 2013


>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera at imgtec.com> writes:

Hi,

 >> > Yes, I sent a pull request upstream and they merged it. If you have
 >> > updated the knock.mk to use the latest git, then we don't need any
 >> > patch because it's already applied upstream :-)
 >> 
 >> True, but the same applies with the current version we're using as that
 >> is from before the README -> README.md rename.

 > Oh, I understand now... You changed the git version of this package to
 > downgrade it just to the point before the README -> README.md was
 > made.

Well, that's one way of seeing it - I fixed it to use the version
specified (7666f2e86e18d4), which was presumably what was the submitter
had desired. Before that fix it used the current head (first time the
package was built, afterwards the local tarball in dl/ is used).


 >> If you have tested the latest git then you are welcome to send a patch
 >> bumping the version.

 > Yes, I have tested it, but it's easier for you to just change the
 > version to the last git commit number.

Do you mind sending a patch changing KNOCK_VERSION so you can sign off
on it? Thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list