[Buildroot] [PATCH] evemu: New package. Also adds libevdev.

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Dec 19 13:46:28 UTC 2013


Yann, Andreas,

Yann's comments are good, I'm just going to add one more below.

On Wed, 18 Dec 2013 18:40:50 +0100, Yann E. MORIN wrote:

> Except for those minor nitpicks, it all Looks Good To Me (TM).

Both packages lack the <pkg>_LICENSE and <pkg>_LICENSE_FILES
informations. See the Buildroot manual for details about these
variables.

Also, the libevdev configure.ac script uses PKG_CHECK_MODULES, so the
package should depend on host-pkgconf. Same thing for evemu.

Finally, your packages don't have any toolchain dependency. This might
be correct, but it would be good if you could test the build of both of
those packages with the following initial configurations:

  http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
  http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config

If it builds fine with both of those toolchain configuration, then
you're good to go. If not, then it means that there are some missing
toolchain dependencies.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list