[Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Feb 12 11:23:23 UTC 2013


Dear Markos Chandras,

On Tue, 12 Feb 2013 10:51:39 +0000, Markos Chandras wrote:
> From: Markos Chandras <markos.chandras at imgtec.com>
> 
> Signed-off-by: Markos Chandras <markos.chandras at imgtec.com>

Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

We often try to keep the define ... endef block within the ifneq
condition, since there is no reason for the VIM_REMOVE_DOCS variable to
be defined if it is useless. But it's not something that has been done
systematically in the entire code base (for example, the
VIM_INSTALL_RUNTIME_CMDS just above your patch, doesn't follow this
rule).

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list