[Buildroot] [PATCH 1/1] libmad: force architecture-specific optimisations on AVR32

[Gilles Talis]

Dear Simon, Benoit and Peter,

2013/2/22 Peter Korsgaard <jacmet at uclibc.org>:
>>>>>> "Simon" == Simon Dawson <spdawson at gmail.com> writes:
>
>  Simon> Hi Gilles,
>  Simon> On 22 February 2013 01:01, Gilles Talis <gilles.talis at gmail.com> wrote:
>  >> Fixes:
>  >> http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22
>  >> http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5d
>  >>
>  >> Signed-off-by: Gilles Talis <gilles.talis at gmail.com>
>
>  Simon> This looks fine, but wouldn't it be simpler to just do
>
>  Simon> config BR2_PACKAGE_LIBMAD
>  Simon>   bool "libmad"
>  Simon>   select BR2_PACKAGE_LIBMAD_ASO if BR2_avr32
>
>  Simon> in the libmad Config.in?
>
> Indeed. That or simply hiding (forcing) the option on avr32, E.G.:
>
> config BR2_PACKAGE_LIBMAD_ASO
>         bool "Architecture-specific optimizations" if !BR2_avr32
>         default y
>
> --
> Bye, Peter Korsgaard
Thanks for your valuable comments. Will send a second version of the
patch with your suggestions later on.

Gilles.