[Buildroot] [PATCH] divine: fix divine-config

Samuel Martin s.martin49 at gmail.com
Fri Jan 4 14:17:42 UTC 2013


Hi Stefan, Gustavo, all,

2013/1/4 Gustavo Zacarias <gustavo at zacarias.com.ar>:
> On 01/03/2013 07:09 PM, Stefan Fröberg wrote:
>
>> +define DIVINE_STAGING_DIVINE_CONFIG_FIXUP
>> +     $(SED) "s,^prefix=.*,prefix=\'$(STAGING_DIR)/usr\',g" $(STAGING_DIR)/usr/bin/divine-config
>> +     $(SED) "s,^exec_prefix=.*,exec_prefix=\'$(STAGING_DIR)/usr\',g" $(STAGING_DIR)/usr/bin/divine-config
>> +endef
>> +
>> +DIVINE_POST_INSTALL_STAGING_HOOKS += DIVINE_STAGING_DIVINE_CONFIG_FIXUP
>> +
>
> This could be handled in a generic way for all the packages that ship a
> *-config file.
> Something like:
>
> DIVINE_CONFIG_FIXUP = divine-config
>
> And then do the generic sed magic in package/pkg-generic.mk
> How about that?

We quickly talked about this during the last Buildroot Dev. Days.

IIRC, Thomas and Peter were not very fond of this kind of solution.
(guys, feel free to correct me if I speak with my ass ;)).

btw, afaics:
- *-config provided by the imagemagick package wrap some calls to pkg-config;
- many packages in BR install handwritten scripts like this, as well
as some *.pc files.
So what about just use pkgconf since it's properly handled in BR?
(I agree it may mean patching many packages that only search for
*-config scripts)
- in this patch serie, only libgcrypt does not provide a *.pc file :-(

Regards,

-- 
Samuel



More information about the buildroot mailing list