[Buildroot] [PATCH v3 1/1] openpgm: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Mar 1 09:24:00 UTC 2013


Dear Alexander Lukichev,

On Fri, 01 Mar 2013 08:46:36 +0200, Alexander Lukichev wrote:

>   I won't do it again but would like to inquire once more about the
> patch. Is it lost/ignored/useless? Maybe it could be improved?

No, it has not been lost. Patches are never lost, because they are
automatically recorded in our Patchwork system, see
http://patchwork.ozlabs.org/project/buildroot/list/. Your patch is
still listed in http://patchwork.ozlabs.org/patch/220105/.

February was the month of the -rc releases, so Peter has been mainly
focused on fixing things and merging fixes. He did merge a few things
in the "next" branch, but not much. Now that 2013.02 has been released,
the "master" branch has reopened to new developments and new packages,
and I expect that Peter will therefore restart merging things more
aggresively.

>   The reason for the patch was to add support for PGM/EPGM protocol
> in zeromq 2.2.0 library, which is already present in Buildroot.

Could you send the patch that makes the ZeroMQ change to use the
openpgm package?

>   On the other hand, support for PGM/EPGM in zeromq can be added
> when it is built also with --with-system-pgm configure option, which
> allows for entirely independent build and installation of openpgm.
> This approach allows to solve openpgm's cross build issues without
> tweaking zeromq. It seemed a cleaner approach, which was taken in
> this patch.

I completely agree with your approach.

>   After this patch is applied, in order to add support for PGM/EPGM
> in zeromq, you have to pass --with-system-pgm option to configure,
> and add a dependency on openpgm package in packages/zeromq/zeromq.mk,
> the patch for which I planned to send if this patch was accepted.

Could you send both patches in a small series of two patches? You don't
need to wait for the first patch to be merged to show the second patch.
Most people do series of patches when they need multiple related things
to be merged (see for example the 30 patches series I sent regarding
Qt5).

>   I have build-tested the patch in several architectures and toolchain
> combinations, and run-tested the built library in x86 (eglibc,
> uClibc 0.9.33) and ARM (uClibc 0.9.33).

Great, thanks for all your testing.

For sure your patch will get merged.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list