[Buildroot] [PATCH] dosfstools: fix host variant dependencies
Yann E. MORIN
yann.morin.1998 at free.fr
Thu Mar 21 12:21:12 UTC 2013
Gustavo, All,
On Thursday 21 March 2013 13:12:34 Gustavo Zacarias wrote:
> host-dosfstools shouldn't pull host-libiconv in since that's for
> uClibc-based toolchains and we don't have that package anyway.
> Fixes:
> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
>
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> ---
> package/dosfstools/dosfstools.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk
> index 332f2ee..79d1c7a 100644
> --- a/package/dosfstools/dosfstools.mk
> +++ b/package/dosfstools/dosfstools.mk
> @@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
> DOSFSTOOLS_LICENSE_FILES = COPYING
> DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
>
> +# Avoid target dosfstools dependencies, no host-libiconv
> +HOST_DOSFSTOOLS_DEPENDENCIES =
> +
Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS =
> ifneq ($(BR2_ENABLE_LOCALE),y)
> DOSFSTOOLS_DEPENDENCIES += libiconv
> DOSFSTOOLS_LDFLAGS += -liconv
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
More information about the buildroot
mailing list