[Buildroot] [PATCH 1/1] cppcms: new package

[Samuel Martin]

2013/5/13 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Dear Samuel Martin,
>
> On Mon, 13 May 2013 17:21:28 +0200, Samuel Martin wrote:
>
>> 2013/4/24 nmenegale <nicolas.menegale at openwide.fr>:
>> > Signed-off-by: Nicolas Ménégale <nicolas.menegale at openwide.fr>
>> > ---
>> > v0: initial commit
>> > CppCMS is a C++ web framework. The cppcms.mk also copy into the host after staging install two
>> > scripts needed when you compile an application using the web framework (cppcms_tmpl_cc and cppcms_run)
>> > As discussed on IRC it's not worth creating an host-cppcms package for two script.
>
> [...]
>
>> > +define CPPCMS_INSTALL_HOST_TOOLS
>> > +       cp $(STAGING_DIR)/usr/bin/cppcms_tmpl_cc $(HOST_DIR)/usr/bin/cppcms_tmpl_cc
>> > +       cp $(STAGING_DIR)/usr/bin/cppcms_run $(HOST_DIR)/usr/bin/cppcms_run
>> Dubious...
>> This means the host-cppcms package should depend on the cppcms one;
>> usually that's the other way!
>>
>> Also, if cppcms_{run,tmpl_cc} are binaries, this may only be valid if
>> the target system is compatible
>> with the host one... which is usually not the case.
>> However, if they're just bash or python scripts, it's ok; though I'd
>> prefer you copy them from the package
>> build directory rather than from the staging tree.
>
> Did you read the commit log?
My bad! I missed it.

>
> Nicolas:
>
>  *) Your commit log lines are too long. Please wrap at ~80 columns.
>
>  *) Your should add a comment in the .mk file to explain what you're
>     doing with those cppcms_tmpl_cc and cppcms_run scripts, so that we
>     remember why the funky thing you're doing works. You can just
>     copy/paste parts of your commit log.
Agree; in the current state, it is/could be a bit confusing...

Regards,

-- 
Samuel