[Buildroot] [PATCH] poco: not available for all architectures

Baruch Siach baruch at tkos.co.il
Thu May 16 11:54:53 UTC 2013


Hi Gustavo,

On Thu, May 16, 2013 at 08:40:01AM -0300, Gustavo Zacarias wrote:
> Missing defines for:
> aarch64, arc, blackfin, microblaze & xtensa.
> Not properly supported: mips - only defines generic mips as BE, doesn't
> know about mipsel (LE) thus assuming it's BE.
> Fixes:
> http://autobuild.buildroot.net/results/9847702b046bed59b07f0e075a58b1f31e9236ce/
> 
> This should be pretty straightforward to fix in
> Foundation/include/Poco/Platform.h for interested parties since it only
> cares about endianness.
> 
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> ---
>  package/poco/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/poco/Config.in b/package/poco/Config.in
> index b823071..402f96d 100644
> --- a/package/poco/Config.in
> +++ b/package/poco/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_POCO
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)
>  	select BR2_PACKAGE_ZLIB
>  	select BR2_PACKAGE_PCRE
>  	help
> @@ -61,3 +62,4 @@ endif # BR2_PACKAGE_POCO
>  comment "poco requires a toolchain with WCHAR, threads, and C++ support"
>  	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
>  		|| !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

Enabling this comment when it is the architecture that is not supported might 
confuse the user. Maybe we should add another comment? How is this handled in 
other packages?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list