[Buildroot] [PATCH v9 05/14] webkit: bump to version 1.9.6

Spenser Gilliland spenser at gillilanding.com
Thu May 30 16:55:39 UTC 2013


On Thu, May 30, 2013 at 11:45 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Spenser Gilliland,
>
> On Thu, 30 May 2013 11:30:28 -0500, Spenser Gilliland wrote:
>>
>> Signed-off-by: Spenser Gilliland <spenser at gillilanding.com>
>> ---
>>  package/webkit/webkit-bison-2-6-compat.patch       |  672 --------------------
>>  package/webkit/webkit-disable-docrebase.patch      |   21 +
>>  package/webkit/webkit-disable-tests.patch          |   76 +++
>>  package/webkit/webkit-execinfo_h.patch             |   24 +
>>  .../webkit-fix-build-issue-with-old-gtk.patch      |   22 -
>>  package/webkit/webkit-fix-build-with-gcc-4-6.patch |   45 --
>>  .../webkit-fix-compilation-on-DirectFB-2.patch     |   33 -
>>  .../webkit-fix-compilation-on-DirectFB.patch       |  144 -----
>>  package/webkit/webkit-fix-pool.patch               |   67 --
>>  package/webkit/webkit-pthread_getattr_np.patch     |   80 ---
>>  package/webkit/webkit.mk                           |   31 +-
>
> When so many patches are added/removed, it'd be good to have a short
> explanation in the commit log as to why such or such patch has been
> removed. Can be simply "drop webkit-fix-pool.patch" because it is
> upstream, or "drop webkit-fix-compilation-on-DirectFB-2.patch because
> we no longer support the DirectFB backend".

Fixed in newest revision. The following text was added to the commit message

    Remove bison-2.6-compat patch as it has been incorporated upstream.
    Remove fix build issue with old gtk as gtk has been bumped to a newer
    version.
    Remove fix-build-with-gcc-4-6 as it has incorporated upstream.
    Remove directfb patches due to depreciation
    Remove pool patch as it is no longer required
    Remove pthread_getattr_np as webkit no longer uses this function.

> Also, the new patches you had lack a header with description and
> Signed-off-by.

Fixed as well.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com



--
Spenser Gilliland
Computer Engineer
Doctoral Candidate



More information about the buildroot mailing list