[Buildroot] [PATCH v2 1/1] ngrep: fix static linking issue with libpcre

Romain Naour romain.naour at openwide.fr
Sat Nov 2 15:46:18 UTC 2013


Le 01/11/2013 17:59, Thomas Petazzoni a écrit :
> Dear Romain Naour,
>
> On Wed, 09 Oct 2013 23:54:22 +0200, Romain Naour wrote:
>> Adding -lpcre in LDFLAGS place the library before object files:
>> gcc ... -lpcre -L .../sysroot/usr/lib -s -o ngrep ngrep.o -lpcap
>>
>> Makefile.in is patched to use @LIBS@ for adding -lpcre in the right place.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/684/684a3bed28d13ef5e5156257aade3b9aff32f180
>>
>> Signed-off-by: Romain Naour <romain.naour at openwide.fr>
> Thanks, but this patch no longer applies on top of master, and more
> importantly, the ngrep-1.45-Makefile.in.patch doesn't apply to the
> ngrep sources. Could you rename the ngrep patches to use numbers, i.e
> ngrep-01-<foo>.patch, and use a more descriptive name than
> ngrep-1.45-Makefile.in.patch?
>
> (Should be done in two patches: one renaming the existing patches, one
> adding the pcre static link fix).
>
> Thanks a lot!
>
> Thomas
Hi Thomas,

Ok, I'll send two patches to fix this issue.

Best regards,
Romain



More information about the buildroot mailing list