[Buildroot] [PATCH v2 3/6] systemd: bump to v206.

Thomas De Schampheleire patrickdepinguin at gmail.com
Mon Nov 4 12:03:41 UTC 2013


Hi,

On Mon, Nov 4, 2013 at 12:45 PM, Eric Le Bihan
<eric.le.bihan.dev at free.fr> wrote:
> On Sat, Nov 02, 2013 at 07:31:39PM +0100, Thomas Petazzoni wrote:
>
[..]
>
>> > +comment 'systemd needs toolchain w/ stack smashing protection'
>> > +   depends on !BR2_TOOLCHAIN_HAS_SSP
>>
>> Wow, that's probably the first package that has this requirement. What
>> happens when the toolchain doesn't have SSP support?
>
> Without SSP, systemd does not build. It is compiled using lots of error
> checking flags (see OUR_CFLAGS in configure.ac), which sounds sensible when
> building a program meant to run as PID 1. This requirement made me report the
> issue "uClibc fails to build with stack smash protection" back in September,
> which was caused by the change in GCC build procedure (two steps instead of
> three).
>

Note that the comments should be '...needs a toolchain...' (with 'a')

I wonder what to do here though. We have deliberately chosen the
toolchain keywords to be short so that the entire line can fit within
a 80-char terminal. 'Stack smashing protection' is pretty long in that
respect.
Not sure if there will be other packages that depend on this option,
but what about we name it just 'SSP' (which also is how it's named in
the toolchain menu). We should probably also update the manual with
this new 'toolchain option' that can have a comment.

Best regards,
Thomas



More information about the buildroot mailing list