[Buildroot] [PATCH 1/1] omniorb: add COS Naming Service

[Matthew Weber]

Arnout Vandecappelle <arnout at mind.be> wrote on 11/12/2013 03:25:40 PM:

> From: Arnout Vandecappelle <arnout at mind.be>
> To: Matt Weber <mlweber1 at rockwellcollins.com>
> Cc: buildroot at busybox.net
> Date: 11/12/2013 03:25 PM
> Subject: Re: [Buildroot] [PATCH 1/1] omniorb: add COS Naming Service
> 
> On 12/11/13 21:31, Matt Weber wrote:
> >
<snip>
> >
> > +define OMNIORB_ENABLE_SERVICES
> > +   $(SED) 's:SUBDIRS += lib:SUBDIRS += lib services:g' 
$(@D)/src/dir.mk
> > +endef
> > +
> > +ifeq ($(BR2_PACKAGE_OMNIORB_WITH_SERVICES),y)
> > +   OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_ENABLE_SERVICES
> 
>   We normally don't indent variable assignments within conditions (the 
> indentation of the sed statement is OK, because that's a shell command).
> 

Sure, I'll clean those up.

>   Also, wouldn't it be better to do this as post-patch hook?

In this case, yes.  The file is not modified during configure.  I'll 
update.

Thanks!
Matt Weber
mlweber1 at rockwellcollins.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/6e73bca7/attachment-0002.html>