[Buildroot] [PATCH v2 1/1] openpowerlink: new package

[Peter Korsgaard]

>>>>> "R" == Romain Naour <romain.naour at openwide.fr> writes:

Hi,

 R> +++ b/package/openpowerlink/Config.in
 R> @@ -0,0 +1,107 @@
 R> +comment "openpowerlink requires thread support in toolchain"
 R> +        depends on !BR2_TOOLCHAIN_HAS_THREADS

It also needs C++ support. From CMakeLists.txt:

PROJECT (openPOWERLINK C CXX)

 R> +
 R> +config BR2_PACKAGE_OPENPOWERLINK
 R> +        bool "openpowerlink"
 R> +        depends on BR2_TOOLCHAIN_HAS_THREADS
 R> +        depends on BR2_i386 || BR2_x86_64
 R> +        help

Your indentation is wrong. Config.in files should be indented with <tab>
(and help lines with <tab><space><space>).

 R> +          openPOWERLINK is an Open Source Industrial Ethernet
 R> +          stack implementing the POWERLINK protocol for Managing Node
 R> +          (MN, POWERLINK Master) and Controlled Node (CN, POWERLINK Slave).
 R> +
 R> +          It is provided by SYSTEC electronic (http://www.systec-electronic.com),

Too long line, please wrap after 'provided by'.

Besides this, it looks good. I did a quick test build with everything
kept to their default and got:

[100%] Built target powerlink
make[2]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
>>> openpowerlink V1.08.3 Installing to staging directory
PATH="/home/peko/source/buildroot/output/host/bin:/home/peko/source/buildroot/output/host/usr/bin:/home/peko/source/buildroot/output/host/usr/sbin/:/home/peko/bin:/home/peko/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/opt/barco/current/usr/bin:/opt/barco/current/usr/bin" PERLLIB="/home/peko/source/buildroot/output/host/usr/lib/perl"  /usr/bin/make -j5  DESTDIR=/home/peko/source/buildroot/output/host/usr/i686-buildroot-linux-uclibc/sysroot install -C /home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/
make[1]: Entering directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make[1]: *** No rule to make target `install'.  Stop.
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make: *** [/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/.stamp_staging_installed] Error 2

So I guess you're missing something?

Please fix and resubmit, thanks.

-- 
Bye, Peter Korsgaard