[Buildroot] [PATCH 1/1] package: fix github download URL

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Oct 1 18:58:49 UTC 2013


Dear Jerzy Grzegorek,

On Tue, 01 Oct 2013 14:24:26 +0200, Jerzy Grzegorek wrote:

> > On 09/26/13 13:43, Jerzy Grzegorek wrote:
> >> diff --git a/package/cpuload/cpuload.mk b/package/cpuload/cpuload.mk
> >> index e0b8ccf..d00c3a4 100644
> >> --- a/package/cpuload/cpuload.mk
> >> +++ b/package/cpuload/cpuload.mk
> >> @@ -4,8 +4,8 @@
> >>   #
> >> ################################################################################
> >>
> >> -CPULOAD_VERSION = v0.3
> >> -CPULOAD_SITE 
> >> =http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION)
> >> +CPULOAD_SITE 
> >> =https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION)
> >>   CPULOAD_LICENSE = GPLv2
> >
> >  Not that it's a big deal to me, but I don't agree with the concept of 
> > this change. The meaning of this URL is that you export a certain tag 
> > from a git repository. It is conceptually not the same as a release 
> > tarball that a project creates. Therefore, I think the VERSION should 
> > be exactly the same as the tag name, so that it stays as close as 
> > possible as what we would have if we used the git site method.
> >
> 
> Take into account that if tag has prefix, BR generates tarball with 
> weird name.
> For instance for libcec:
> tag: libcec-2.1.1
> LIBCEC_VERSION = libcec-2.1.1
> LIBCEC_SITE = 
> https://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION)
> tarball name downloaded by BR: libcec-libcec-2.1.1.tar.gz
> 
> but when
> LIBCEC_VERSION = 2.1.1
> LIBCEC_SITE = 
> https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION)
> the tarball name generated by github matches the one from BR: 
> libcec-2.1.1.tar.gz

I tend to agree with Arnout. We don't care if tarballs have weird
names, upstream projects should simply learn to name their tags
properly. Having <pkg>_VERSION match the Git tag name seems more
important to me than having nice tarball names.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list