[Buildroot] [PATCHv2 04/21] toolchain: move helpers.mk into toolchain-external/

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Oct 6 21:26:08 UTC 2013


Dear Peter Korsgaard,

On Sun, 06 Oct 2013 21:31:46 +0200, Peter Korsgaard wrote:

>  Thomas> -include toolchain/helpers.mk
>  Thomas> -
> 
> That doesn't seem right as we have:
> 
> git grep copy_toolchain package/
> package/glibc/glibc.mk:         $(call copy_toolchain_lib_root,$(STAGING_DIR)/,,

Oh, I'm impressed how well you know the code, even code that I have
written. We really need some kind of "test suite" to check patches or
something like that: a patch set such as this toolchain-related patch
set is really a pain to test in all the various possible conditions. I
did test the internal backend, but only with uClibc toolchain.

I'll rework my patch series.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list