[Buildroot] [PATCH 1/1] trace-cmd: use pkg-config instead of python-config

Peter Korsgaard jacmet at uclibc.org
Mon Oct 14 10:52:36 UTC 2013


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 >> +++ b/package/trace-cmd/Config.in
 >> @@ -2,6 +2,8 @@ config BR2_PACKAGE_TRACE_CMD
 >> bool "trace-cmd"
 >> depends on BR2_LARGEFILE
 >> depends on BR2_TOOLCHAIN_HAS_THREADS
 >> +	select BR2_PACKAGE_PYTHON

 Thomas> No, Python support is optional in trace-cmd. We should keep optional,
 Thomas> by doing:

 Thomas> ifeq ($(BR2_PACKAGE_PYTHON),)
 Thomas> TRACE_CMD_MAKE_FLAGS += -NO_PYTHON=1
 Thomas> else
 Thomas> TRACE_CMD_DEPENDENCIES += python
 Thomas> endif

Actually I prefer positive logic, E.G.:

ifeq ($(BR2_PACKAGE_PYTHON),y)
TRACE_CMD_DEPENDENCIES += python
else
TRACE_CMD_MAKE_FLAGS += -NO_PYTHON=1
endif

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list