[Buildroot] [PATCH v8 RESEND 1/8] package: add base dependency to every package

Fabio Porcedda fabio.porcedda at gmail.com
Fri Oct 25 08:45:39 UTC 2013


On Fri, Oct 25, 2013 at 10:12 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 25/10/13 10:07, Fabio Porcedda wrote:
>>
>> On Thu, Oct 24, 2013 at 12:37 PM, Arnout Vandecappelle<arnout at mind.be>
>> wrote:
>>>
>>> >On 24/10/13 09:41, Fabio Porcedda wrote:
>>>>
>>>> >>
>
> [snip]
>
>>>> >>I've found a work around:
>>>> >>
>>>> >>$$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dirs prepare
>>>> >>
>>>> >># to prevent circular dependency
>>>> >>ifneq ($(1),$(DEPENDENCIES_HOST_PREREQ))
>>>> >>$$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dependencies
>>>> >>endif
>>>> >>
>>>> >>What do you think about that?
>>>
>>> >
>>> >
>>> >  Looks good except that it's incorrect:-)  If HOST_PREREQ contains both
>>> >ccache and sstrip (not to mention tar or xz), the condition won't match.
>>> > You
>>> >can try something like:
>>> >
>>> >ifeq ($(filter $(1),$(DEPENDENCIES_HOST_PREREQ)),)
>>
>> Ok good, I've updated the patch according.
>>
>
>  Have you tested it with various combinations of dependencies?

I've tested enabling "BR2_CCACHE" and "BR2_STRIP_sstrip" with
qemu_x86_defconfig and seems works fine.
The circular dependencies are gone.
I think the patch now does not introduce any regression.

I'm testing the whole patch set with top-level parallel make and
enabling "BR2_CCACHE" and "BR2_STRIP_sstrip".

Thanks and regards
-- 
Fabio Porcedda



More information about the buildroot mailing list