[Buildroot] [PATCH 5/5] thrift: new package
Ryan Barnett
rjbarnet at rockwellcollins.com
Mon Oct 28 14:11:16 UTC 2013
Gustavo, Arnout,
Gustavo Zacarias <gustavo at zacarias.com.ar> wrote on 10/28/2013 06:02:30
AM:
> On 10/28/2013 04:24 AM, Arnout Vandecappelle wrote:
>
> > But not as much as requiring 80 hashes in the header :-)
>
> Pfffft, that's not mine :)
>
> > It's not because it wasn't done right in the past that it shouldn't
be
> > done right now :-)
>
> Some licenses were defined a few days ago that weren't the last lines
> before defines and nobody said anything, you should have shown up then
:P
>
> > I agree with Ryan that it would be a good idea to standardize on some
> > order of the variable definitions. But since there is not standard at
> > the moment, we have to wait for an edict from Peter before we can
> > enforce it.
>
> Propose it then and get it rolling, for the time being there's no rule
> about it.
I never was intending for you to change it, rather it was a suggestion and
I don't have any standard to fall back on to back me up.
> > That it's implicit from openssl is not really relevant - if the
> > dependency is ever removed from openssl (OK, this will not happen, but
> > just imagine) then we'd like to keep the correct dependency here.
>
> Ok.
> All the packages that use openssl should be checked though, almost none
> of them do zlib either (doesn't mean they use it directly, but a good
> check wouldn't hurt).
I guess all I really care about is a comment in regards to zlib being
built from having dependancy on openssl. I don't always remember these
things so just a friendly reminder comment is good enough.
Thanks,
-Ryan
More information about the buildroot
mailing list