[Buildroot] [PATCH 5/5] thrift: new package

[Gustavo Zacarias]

On 10/28/2013 11:11 AM, Ryan Barnett wrote:

>>>  That it's implicit from openssl is not really relevant - if the
>>> dependency is ever removed from openssl (OK, this will not happen, but
>>> just imagine) then we'd like to keep the correct dependency here.
>>
>> Ok.
>> All the packages that use openssl should be checked though, almost none
>> of them do zlib either (doesn't mean they use it directly, but a good
>> check wouldn't hurt).
> 
> I guess all I really care about is a comment in regards to zlib being 
> built from having dependancy on openssl. I don't always remember these 
> things so just a friendly reminder comment is good enough.

Point is thrift has a hard dependency on zlib right now (regardless of
openssl, for channel compression) so it is a dependency.
It can be built without it and loose the TZlibTransport but really it's
already pulled in by openssl so making it optional is kind of pointless.
What should be checked is the same holding true for other packages that
do use openssl and _maybe_ use zlib as well in a separate fashion which
haven't accounted for it (like thrift).
So the comment itself wouldn't apply, pulling in zlib does (select +
DEPENDENCIES) which is what i'm doing for the next patchset version.
Regards.