[Buildroot] [git commit] libevas: async image preload support needs threads support in toolchain

Peter Korsgaard jacmet at sunsite.dk
Wed Sep 4 11:55:29 UTC 2013


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> Dear Peter Korsgaard,
 Thomas> On Wed, 4 Sep 2013 13:31:19 +0200, Peter Korsgaard wrote:

 >> +# async image preload support needs threads support in toolchain
 >> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)

 Thomas> Maybe using positive logic would have been better, no?

 Thomas> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
 Thomas> ...
 Thomas> endif

Perhaps. I don't really feel strongly about it, and we do have quite a
mix today:

git grep 'ifneq.*,y)' package | wc -l
164

git grep 'ifeq.*,)' package/|wc -l
85

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list