[Buildroot] [PATCH v2 1/2] getty: Create specific getty config + cleanups

Thomas De Schampheleire patrickdepinguin+buildroot at gmail.com
Fri Sep 6 08:18:43 UTC 2013


On Fri, Sep 6, 2013 at 8:59 AM, Assaf Inbal <shmuelzon at gmail.com> wrote:
> Hey,
>
>> I haven't seen a new version yet. When you have some time, could you
>> do it? I think the patch series is a nice improvement so I don't want
>> to loose this...
>
> Sorry, got caught up by my actual day job :)
> Two quick questions:
> - Would it be better to create a sub menu called "getty options"? I
> think that otherwise it would be clear what these options refer to. It
> would also clean up the main "system" menu.

We don't usually have real submenus in buildroot, but I don't have a
very strong opinion on this.

> - In order to avoid the new thread that started with the 2nd version
> of the patch, how should I configure git send-email to reply to this
> thread? I altered the "reply-to" field but that didn't seem to work.

There are different opinions in the buildroot community regarding the
desirability of such in-reply-to patches. I'm personally not an
opponent of it, for the following reasons:

1. from the list of e-mails (in gmail for example) it is unclear if
the new reply is just a comment on the current version of the patch,
or if it is a new version. You really have to check the reply.

2. it doesn't work well for patch series: the first patch would indeed
be a reply to the previous thread, but all other patches would not.
This makes it very annoying to read all patches in a series.

Therefore, I always send new versions as new standalone e-mails, with
a marker vX to indicate the version. Several other buildroot
contributors do the same.

Best regards,
Thomas



More information about the buildroot mailing list