[Buildroot] [PATCH v2 03/17] ustr: new package
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Sep 12 19:34:30 UTC 2013
Dear Clayton Shotwell,
On Wed, 11 Sep 2013 16:59:23 -0500, Clayton Shotwell wrote:
> .../ustr/ustr-0001-crossCompileModifications.patch | 144 ++++++++++++++++++++
Please name the patch:
ustr-0001-cross-compile-modifications.patch
The naming of patch files should be fixed globally in the patch series.
We use lower case names, with '-' as the separator between words in the
patch description.
Also, this package doesn't build properly when the toolchain does not
have large file support. Just like libselinux, the Makefile hardcodes
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE. Your options are either to
make ustr depend on large file support in the toolchain, or to modify
the Makefile.
Other than that, looks good.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list