[Buildroot] [PATCH 1/1] package: remove the trailing slash sign from the URL address
Jerzy Grzegorek
jerzy.grzegorek at trzebnica.net
Fri Sep 20 06:23:22 UTC 2013
Hi Michael,
Thanks for your feedback.
> Hi Arnout and Jerzy,
>
> of course, Arnout is right that the change of the URLs in the _SITE variables is not that relevant.
> My comment was more targeted to all the other URLs for the upstream projects. Which I now see,
> was not part of your original patch submission. Sorry, that I overlooked that.
No problem.
Yes, the subject of my patch submission is removing the trailing slash
from _SITE variables only.
I see now that the title is a little bit misleading.
> But since I thought you overall wanted to have more consistency with all the URLs, I decided
> to quickly analyse what else we do have in our Config.ins:
>
> Apart from the _SITE URLs, we have:
> - 751 packages, where another URL is used to point to the upstream project
> - 465 of these 751 had a trailing slash at the end of the URL
>
> I then tried to analyse, whether there is a need to modify them:
> - 726 were HTTP Urls where the server responded with:
> 535 200 OK
> 132 301 Moved Permanently
> 42 302
> 1 400
> 2 403
> 13 404
> 1 500
> - 71 of the 132 moved URLs had a trailing slash at the end of their new locations.
>
> Used scripts:
> find package/ -name "Config.in" -exec egrep -i " (ht|f)tp://.*$" {} \; >../buildroot-urls.txt
> cat buildroot-urls.txt |xargs -i ./show_response.sh {} >buildroot-checked-urls.txt
> egrep "^HTTP" buildroot-checked-urls.txt |sed -e "s/HTTP\/.\.. \(...\) .*$/\1/g" | sort | uniq -c
>
> show_response.sh just invokes curl.
> #! /bin/bash
> ARG=$*
> echo "Original URL: " $ARG
> echo "Response: "
> curl -I $ARG 2>/dev/null |egrep "^(HTTP/|Location:)"
> echo
>
> I made the input files available at:
>
> http://michaelrommel.com/buildroot-urls.txt
> http://michaelrommel.com/buildroot-checked-urls.txt
> http://michaelrommel.com/buildroot-moved-urls.txt
Interesting...
I think, this information will certainly be useful for the BR upstream
projects
and patches.
Regards,
Jerzy
> to avoid clutter on this list.
>
> Michael.
>
More information about the buildroot
mailing list