[Buildroot] [PATCH] xapp_xscreensaver: new package

[Simon Dawson]

On 23 September 2013 08:44, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "spdawson" == spdawson  <spdawson at gmail.com> writes:
>  spdawson> +            source package/x11r7/xapp_xscreensaver/Config.in
>
> Like Thomas commented on the recently posted lesstif package, this
> shouldn't go under x11r7 as it isn't part of x.org (and should just be
> called xscreensaver).

Okay; I'll move it.

>  spdawson> +XAPP_XSCREENSAVER_LICENSE = MIT-like
>  spdawson> +XAPP_XSCREENSAVER_LICENSE_FILES = hacks/screenhack.h
>
> According to the Debian package, it also contains GPLv2+ parts
> (hacks/glx/chessmodels.{c,man}), but perhaps we don't build that file?
>
> A comment explaining it might be good.

Ah, right. I'll fix this then.

>  spdawson> +XAPP_XSCREENSAVER_CONF_OPT += \
>  spdawson> +    CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include" \
>  spdawson> +    LDFLAGS="$(TARGET_LDFLAGS) -L$(STAGING_DIR)/usr/lib" \
>
> The compiler should already be looking under STAGING_DIR, why is this
> needed?

Right; not needed, in fact. I'll remove this in the next iteration of the patch.

Simon.