[Buildroot] [PATCH v4 3/3] package/Makefile.in: add a way to don't force jobs in sub-make

Fabio Porcedda fabio.porcedda at gmail.com
Mon Sep 23 08:00:34 UTC 2013


On Fri, Sep 20, 2013 at 4:57 PM, Fabio Porcedda
<fabio.porcedda at gmail.com> wrote:
> On Thu, Sep 19, 2013 at 9:11 AM, Thomas De Schampheleire
> <patrickdepinguin at gmail.com> wrote:
>> Hi Fabio,
>>
>> On Thu, Sep 19, 2013 at 8:59 AM, Fabio Porcedda
>> <fabio.porcedda at gmail.com> wrote:
>> [..]
>>>> In fact, we don't add a way, since the user cannot choose to force or not.
>>>
>>> IMHO the user can choose  by means of the "BR2_JLEVEL" variable, if
>>> that variable contains a value buildroot will force the number of
>>> jobs, if that variable is empty buildroot will not force the number of
>>> jobs.
>>
>> True, but BR2_JLEVEL was already there before your patch. What your
>> patch fixes is the situation where BR2_JLEVEL is empty, not 0, 1, 2,
>> 3, ... as the original code expected. So, maybe a better title is:
>>
>> package/Makefile.in: don't force parallel building when BR2_JLEVEL is empty
>
> Ok it's fine for me.

Well the line it's too long (75 character), i will use:

package/Makefile.in: don't force jobs when BR2_JLEVEL is empty

Best regards
-- 
Fabio Porcedda



More information about the buildroot mailing list