[Buildroot] [PATCH 1 of 2] make clean: improve when no .config present
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon Sep 30 12:04:38 UTC 2013
Dear Thomas De Schampheleire,
On Mon, 30 Sep 2013 13:09:26 +0200, Thomas De Schampheleire wrote:
> The 'make clean' recipe is using variables that are not defined without .config
> file, causing only a partial cleanup when the .config file is accidentally
> deleted.
>
> This patch moves those variables that do not depend on values from .config
> outside the BR2_HAVE_DOT_CONFIG check, so that 'make clean' is much more similar
> with and without .config.
Yeah, this has bothered me for a while, so I agree with that.
> The HOST_DIR (and the derived STAGING_DIR) are determined from BR2_HOST_DIR in
> .config, so the host directory can still not be cleaned correctly without making
> assumptions, if no .config is present.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>
> ---
> Note: we could improve the HOST_DIR cleanup by removing 'output/host'
> unconditionally, but it's an assumption. Let me know your thoughts on this, it
> could be fixed in another patch.
Hum, yeah, indeed. This means that the contents of output/host are not
removed, which is quite annoying. I don't immediately see a solution to
this problem, though.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list