[Buildroot] [PATCH] postgresql: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Apr 3 20:39:52 UTC 2014


Dear Peter Seiderer,

On Mon, 31 Mar 2014 08:59:29 +0200, Peter Seiderer wrote:

> diff --git a/package/postgresql/Config.in b/package/postgresql/Config.in
> new file mode 100644
> index 0000000..bc0305b
> --- /dev/null
> +++ b/package/postgresql/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_POSTGRESQL
> +	bool "PostgreSQL"

lower case, please.

> +	depends on BR2_INET_IPV6

Since it currently doesn't build with uClibc, can you make this package
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?


> +if [ ! -f /srv/pgsql/data/PG_VERSION ]; then

I thought we changed to /var/lib/pgsql ?

Maybe you should create a variable that contains /var/lib/pgsql to
avoid this duplication.


> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +	POSTGRESQL_DEPENDENCIES += zlib
> +else
> +	POSTGRESQL_CONF_OPT += --wihtout-zlib

Typo.

> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +	POSTGRESQL_DEPENDENCIES += openssl
> +	POSTGRESQL_CONF_OPT += --with-openssl

else
	POSTGRESQL_CONF_OPT += --without-openssl

Other than that, looks good.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list