[Buildroot] [[RFC]] toolchain: print actual version of kernel headers when checking

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Apr 6 12:28:50 UTC 2014


Dear Yann E. MORIN,

On Sun, 30 Mar 2014 14:59:30 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> 
> Reported-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  support/scripts/check-kernel-headers.sh | 39 ++++++++++++++++++++++++++++-----
>  toolchain/helpers.mk                    |  3 +--
>  2 files changed, 35 insertions(+), 7 deletions(-)

I've applied the patch with the following changes:

 * Modified the commit log to add the message you suggested.

 * Fix the coding style: no space after opening parenthesis, no space
   before closing parenthesis.

 * Adjust the error message so that it fits on one line, which I
   believe is clearer.

Also, I'm not entirely sure about the usage of $(uuidgen). Should we use
mktemp instead?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list