[Buildroot] [PATCH 01/20] package/libgles: rename the _HAS and _PROVIDES variables

Yann E. MORIN yann.morin.1998 at free.fr
Fri Apr 4 20:23:18 UTC 2014


Arnout, All,

On 2014-04-04 18:41 +0200, Arnout Vandecappelle spake thusly:
> On 10/03/14 21:27, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > 
> > The basic rule for a package is to have its options named
> > after the package name. There is no reason this should not
> > also be the case for virtual packages.
> > 
> > Besides, this will allow us to switch libgles to use the
> > soon-to-be-introduced virtual-package infrastructure.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > Cc: Eric Le Bihan <eric.le.bihan.dev at free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> > Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> > Cc: Mike Zick <minimod at morethan.org>
> > Cc: Samuel Martin <s.martin49 at gmail.com>
> > Reviewed-by: Samuel Martin <s.martin49 at gmail.com>
> 
>  It no longer applies as is (well, it applies but it is not 
> correct anymore; it misses the new mesa3d and xbmc). Instead, 
> the change should be done with:
> 
> git grep -l 'BR2_PACKAGE_\(HAS\|PROVIDES\)_OPENGL_ES' | xargs sed -i 's/BR2_PACKAGE_\(HAS\|PROVIDES\)_OPENGL_ES/BR2_PACKAGE_\1_LIBGLES/g'

That's basically how I did generate those patches (IIRC).

I have anyway already rebased this on top of current master.
I was waiting for things to settle down a bit before I re-submitted
an updated series.

>  Other than that it gets my ack.

Thanks. :-)

>  Same for the next 4 patches: use the automated change 
> and it gets my ack.
> 
>  Please apply soonish to avoid further changes.

Hehe! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list