[Buildroot] [PATCH v2] ne10: bump version to 1.0.0

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Apr 13 08:54:15 UTC 2014


Dear Baruch Siach,

On Sun, 13 Apr 2014 11:33:56 +0300, Baruch Siach wrote:

> diff --git a/package/ne10/Config.in b/package/ne10/Config.in
> index d0c4983ed588..fa21cc4f084c 100644
> --- a/package/ne10/Config.in
> +++ b/package/ne10/Config.in
> @@ -1,6 +1,8 @@
>  config BR2_PACKAGE_NE10
>  	bool "ne10"
> -	depends on BR2_arm && BR2_ARM_CPU_HAS_NEON
> +	depends on BR2_arm
> +	depends on BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4

Hum, why BR2_ARM_CPU_HAS_NEON isn't sufficient here? I believe you can
very well have a root filesystem that is generally built with
BR2_ARM_FPU_VFPV4 (i.e the default FPU used is VFPv4), but still build
some software packages to use Neon instructions, as long as
BR2_ARM_CPU_HAS_NEON is defined.

> +	depends on BR2_ARM_INSTRUCTIONS_THUMB || BR2_ARM_INSTRUCTIONS_THUMB2

Same thing here: nothing prevents you from building your root
filesystem with full ARM instructions (i.e
BR2_ARM_INSTRUCTIONS_ARM_CHOICE), but still build some software
packages to use Thumb2 instructions, as long as BR2_ARM_CPU_HAS_THUMB2
is defined.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list