[Buildroot] [PATCH v4 1/4] Makefile: fix coding style
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Apr 16 17:42:15 UTC 2014
Dear Fabio Porcedda,
On Mon, 7 Apr 2014 11:56:47 +0200, Fabio Porcedda wrote:
> As stated in the buildroot user manual add just a single space before
> and after a '=' sign.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
> ---
> Makefile | 184 +++++++++++++++++++++++++++++++--------------------------------
> 1 file changed, 92 insertions(+), 92 deletions(-)
To be honest, while I definitely value the change to harmonize the
coding style, such a large patch touching almost every line of the main
Makefile is a recipe for conflicts with many other patches. So I would
personally prefer to not apply this patch, and do the coding style
fixes progressively, as we make other changes to the main Makefile.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list