[Buildroot] [PATCH v4 2/4] toolchain: add a hidden config option to enable the toolchain package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Apr 16 17:43:08 UTC 2014


Dear Fabio Porcedda,

On Mon,  7 Apr 2014 11:56:48 +0200, Fabio Porcedda wrote:
> The usual way to enable a package using the package infrastructure is to
> use a config option so instead to add the toolchain package to the
> TARGETS variable in the Makefile add a config option like all the other
> toolchain packages.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>
> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
> ---
>  Makefile            | 2 +-
>  toolchain/Config.in | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)

I've applied this patch, which conflicted because it was based on the
previous patch :)

> diff --git a/Makefile b/Makefile
> index 82f2763..e0831b6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -299,7 +299,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
>  #
>  ################################################################################

I've removed this big comment here that was no longer making any sense.

> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 44f3ac6..94a0c7d 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -1,5 +1,9 @@
>  menu "Toolchain"
>  
> +config BR2_TOOLCHAIN

And added a comment above this, to explain what it's useful for.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list