[Buildroot] [PATCH 1/1] libdrm: needs threads

[Romain Naour]

Hi Yann,

Le 21/04/2014 19:32, Yann E. MORIN a écrit :
> Romain, All,
> 
> On 2014-04-21 19:28 +0200, Romain Naour spake thusly:
>> libdrm select libpthread-stubs that needs threads support.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/1da/1dad13110312a44b40b9ee4050b265de1f3c8a42/build-end.log
>>
>> Signed-off-by: Romain Naour <romain.naour at openwide.fr>
>> ---
>>  package/libdrm/Config.in | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
>> index 72cf5f8..fdb541e 100644
>> --- a/package/libdrm/Config.in
>> +++ b/package/libdrm/Config.in
>> @@ -1,6 +1,7 @@
>>  config BR2_PACKAGE_LIBDRM
>>  	bool "libdrm"
>>  	select BR2_PACKAGE_LIBPTHREAD_STUBS
>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
>>  	depends on BR2_LARGEFILE
>>  	help
>>  	  Direct Rendering Manager
>> @@ -59,5 +60,6 @@ endmenu
>>  
>>  endif
>>  
>> -comment "libdrm needs a toolchain w/ largefile"
>> +comment "libdrm needs a toolchain w/ largefile, threads"
>>  	depends on !BR2_LARGEFILE
>> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> 
> This should be:
>     depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> 
> Otherwise, the comment is only visible when both are not set, while we
> want to see the comment as soon as at least one is not set.
> 

Thanks, I'll send a new patch.

Best regards,
Romain