[Buildroot] [PATCH] glm: Added package
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Aug 6 20:12:47 UTC 2014
Dear Paul Cercueil,
On Wed, 6 Aug 2014 00:59:17 +0200, Paul Cercueil wrote:
> diff --git a/package/glm/Config.in b/package/glm/Config.in
> new file mode 100644
> index 0000000..2897cf0
> --- /dev/null
> +++ b/package/glm/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_GLM
> + bool "glm"
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + OpenGL Mathematics (GLM)
> +
> + http://glm.g-truc.net
This lacks a comment explaining that this package depends on C++ when
C++ is not available (see the Buildroot manual and many other packages
in Buildroot).
> diff --git a/package/glm/glm.mk b/package/glm/glm.mk
> new file mode 100644
> index 0000000..1e7e7df
> --- /dev/null
> +++ b/package/glm/glm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# glm
> +#
> +#############################################################
Header length is not correct (80 # signs are needed), and there should
be an empty line between the header and the first variable definition.
> +GLM_VERSION = 0.9.5.4
> +GLM_SITE = git://github.com/g-truc/glm.git
github helper, as pointed by Baruch.
> +GLM_LICENSE = MIT
> +GLM_LICENSE_FILES = copying.txt
> +GLM_INSTALL_STAGING = YES
> +GLM_INSTALL_TARGET = NO
Could you add a small comment above those two lines to explain why no
target installation is needed?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list