[Buildroot] [PATCH 1/1] postgresql: remove devfiles from target

Floris Bos bos at je-eigen-domein.nl
Tue Aug 12 17:39:20 UTC 2014


Hi,

On 08/12/2014 06:50 PM, Thomas Petazzoni wrote:
> On Sun, 10 Aug 2014 14:54:51 +0200, Thomas De Schampheleire wrote:
>
>>>> Not entirely sure here, but isn't the better approach for pg_config to add
>>>> it to POSTGRESQL_CONFIG_SCRIPTS? This will ensure the file is fixed up for
>>>> staging usr, and removed from target automatically.
>>>>
>>> Note that pg_config is an ELF executable compiled for the target
>>> architecture, and not a text script that can be easily fixed up.
>> Ok, in this case adding it to POSTGRESQL_CONFIG_SCRIPTS may not be the
>> best idea.
> More precisely: it will simply not work. The <pkg>_CONFIG_SCRIPTS
> mechanism assumes that the <pkg>-config files are shell scripts, in a
> certain format. With an ELF executable compiled for the target:
>
>   1/ There's no way the <pkg>_CONFIG_SCRIPTS mechanism can work
>
>   2/ There's no real point in keeping this file on the build machine,
>      because it's an executable built for the target.

Do wonder if we shouldn't provide a simple replacement script for 
pg_config, e.g. just implementing "--includedir" and "--libdir"
Might be less work than patching configure scripts that want to call 
pg_config.


Yours sincerely,

Floris Bos



More information about the buildroot mailing list