[Buildroot] [PATCH 2/2] rp-pppoe: install helper scripts

Peter Korsgaard peter at korsgaard.com
Wed Dec 3 22:45:22 UTC 2014


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 > On a second thought, we could do:

 > RP_PPPOE_TARGET_FILES = src/foo src/bar scripts/baz scripts/bleh

 > and then do:

 > 	for ff in $(RP_PPPOE_TARGET_FILES); do \
 > 		$(INSTALL) -m 0755 $(@D)/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
 > 	done

Then you whould need to strip the directory part of $$ff for the
destination to not end up in $(TARGET_DIR)/usr/sbin/src/foo.

 > Not sure it matters much, though.

I think keeping it in two loops is a bit more readable.

-- 
Venlig hilsen,
Peter Korsgaard 



More information about the buildroot mailing list