[Buildroot] [PATCH 3/3 v2] fs/ext2: add option to specify a filesystem label

Yann E. MORIN yann.morin.1998 at free.fr
Sat Dec 6 12:20:54 UTC 2014


Károly, All,

On 2014-12-06 12:59 +0100, Károly Kasza spake thusly:
> --- a/fs/ext2/ext2.mk
> > +++ b/fs/ext2/ext2.mk
> > @@ -18,6 +18,12 @@ ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_RESBLKS)),0)
> >  EXT2_OPTS += -r $(BR2_TARGET_ROOTFS_EXT2_RESBLKS)
> >  endif
> >
> > +# Not qstrip-ing the variable, because it may contain spaces,
> > +# but we must qstrip it when checking.
> > +ifneq ($(call qstrip,$(BR2_TARGET_ROOTFS_EXT2_LABEL)),)
> > +EXT2_OPTS += -l $(BR2_TARGET_ROOTFS_EXT2_LABEL)
> >
> 
> Unfortunately this won't work with labels with spaces in them.
> I recommend using escaped quotation marks like this:
> 
> +EXT2_OPTS += -l \"$(BR2_TARGET_ROOTFS_EXT2_LABEL)\"

Damit... Right, I'll fix and respin.

Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list