[Buildroot] [PATCH v11 2/8] package: add toolchain dependency to every target package

Fabio Porcedda fabio.porcedda at gmail.com
Fri Feb 7 12:57:24 UTC 2014


On Fri, Jan 10, 2014 at 11:06 AM, Fabio Porcedda
<fabio.porcedda at gmail.com> wrote:
<snip>
> -
> -$(2)_DEPENDENCIES ?= $(filter-out $(1),$(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES))))
> +# When a target package is a toolchain dependency set this variable to
> +# 'NO' so the 'toolchain' dependency is not added to prevent a circular
> +# dependency
> +$(2)_ADD_TOOLCHAIN_DEPENDENCY  ?= YES
>
> +$(2)_DEPENDENCIES ?= $(filter-out  host-toolchain $(1),\
> +       $(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES))))
> +ifeq ($(5),target)

This line should be changed to:

ifeq ($(4),target)

After the recently merged commit 26aef889f1df32d5a15cd70f6b1e316ebb830cb7
(infra: remove unused 4th parameter to package infrastructures (pkgparentdir))
the $(4) must be used instead of $(5).

Do you prefer that i send a fixed patch series or  i send a new commit
to fix that?
Which solution do you prefer?
If you prefer i can send a new version today.
I just don't want to delay anymore the merge of this patch series.

Best regards
Fabio Porcedda


More information about the buildroot mailing list