[Buildroot] [PATCH 1/4] luajit: refactor without dont-strip.patch
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Feb 27 22:59:52 UTC 2014
Dear Francois Perrad,
On Thu, 23 Jan 2014 09:28:30 +0100, Francois Perrad wrote:
> the variable TARGET_STRIP does the job
>
> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> ---
> package/luajit/luajit-03-dont-strip.patch | 23 -----------------------
> package/luajit/luajit.mk | 2 +-
> 2 files changed, 1 insertion(+), 24 deletions(-)
> delete mode 100644 package/luajit/luajit-03-dont-strip.patch
Looks good to me. Just a question below.
> + TARGET_STRIP=@: \
Any reason to use @: instead of just : ?
Also, personally, I would probably prefer TARGET_STRIP=true. I know
it's the same, but I find the usage of ':' a bit hard to read.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list