[Buildroot] [PATCH] dependencies.sh: cleanup dependencies.sh

Maxime Hadjinlian maxime.hadjinlian at gmail.com
Tue Feb 4 22:35:23 UTC 2014


On 4 Feb 2014 17:20, "Luca Ceresoli" <luca at lucaceresoli.net> wrote:
>
> Hi Maxime,
Hi Luca,
>
>
> Maxime Hadjinlian wrote:
>>
>> Cleanup mixed indents and remove commented lines.
>>
>> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
>> ---
>>   support/dependencies/dependencies.sh | 214
+++++++++++++++++------------------
>>   1 file changed, 107 insertions(+), 107 deletions(-)
>>
>> diff --git a/support/dependencies/dependencies.sh
b/support/dependencies/dependencies.sh
>> index 47d4d10..06386e6 100755
>> --- a/support/dependencies/dependencies.sh
>> +++ b/support/dependencies/dependencies.sh
>> @@ -1,199 +1,199 @@
>>   #!/bin/sh
>>   # vi: set sw=4 ts=4:
>> -#set -x
>>
>>   export LC_ALL=C
>>
>>   # Verify that grep works
>>   echo "WORKS" | grep "WORKS" >/dev/null 2>&1
>>   if test $? != 0 ; then
>> -       echo
>> -       echo "grep doesn't work"
>> -       exit 1
>> +echo
>> +echo "grep doesn't work"
>> +exit 1
>>   fi
>
>
> Are you really suggesting we should remove all nesting? Well, I guess
> there's been a problem with the e-mail or something...
Well, I asked Peter before doing this, the file contained mixed indents. We
thought it would be nice to have a consistent indent with the Mk files.

But if we find we don't want that because it removes clarity in the code. I
can perfectly resend with only the space/tab fixed.

I really don't have a strong opinion on this one. Thomas Petazzoni and Yann
E. Morin also found it disturbing.
Peter what is your decision ?
>
> --
> Luca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140204/9857cf9c/attachment-0002.html>


More information about the buildroot mailing list